Uploaded image for project: 'TinkerPop'
  1. TinkerPop
  2. TINKERPOP-1146

IoTest are not clearing the db after the test run

    Details

      Description

      IoTest.shouldReadWriteSelfLoopingEdges are not clearing the db after the test run.

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/incubator-tinkerpop/pull/223

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/incubator-tinkerpop/pull/223
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user twilmes commented on the pull request:

        https://github.com/apache/incubator-tinkerpop/pull/223#issuecomment-182941845

        VOTE +1

        Show
        githubbot ASF GitHub Bot added a comment - Github user twilmes commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/223#issuecomment-182941845 VOTE +1
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user spmallette commented on a diff in the pull request:

        https://github.com/apache/incubator-tinkerpop/pull/223#discussion_r52587408

        — Diff: docs/src/upgrade/release-3.1.x-incubating.asciidoc —
        @@ -22,6 +22,32 @@ image::https://raw.githubusercontent.com/apache/incubator-tinkerpop/master/docs/

        A 187 On The Undercover Gremlinz

        +TinkerPop 3.1.2
        +---------------
        +
        +Release Date: NOT OFFICIALLY RELEASED YET
        +
        +Please see the link:https://github.com/apache/incubator-tinkerpop/blob/3.1.1-incubating/CHANGELOG.asciidoc#tinkerpop-312-release-date-XXXXXXXXXXXXXXXXXXXXXXXXXX[changelog] for a complete list of all the modifications that are part of this release.
        +
        +Upgrading for Providers
        +~~~~~~~~~~~~~~~~~~~~~~~
        +
        +IMPORTANT: It is recommended that providers also review all the upgrade instructions specified for users. Many of the
        +changes there may prove important for the provider's implementation.
        +
        +Graph System Providers
        +^^^^^^^^^^^^^^^^^^^^^^
        +
        +GraphProvider.clear() Semantics
        ++++++++++++++++++++++++++++++++
        +
        +The semantics of the various `clear()` methods on `GraphProvider` didn't really change, but it would be worth reviewing
        +their implementations to ensure that implementations can be called successfully in an idempotent fashion. Multiple
        +calls to `clear()` may occur for a single test on the same `Graph` instance, as `3.1.1-incubating` introduced an
        — End diff –

        It should be as-is - that feature came in at that version, but came with the described limitation

        Show
        githubbot ASF GitHub Bot added a comment - Github user spmallette commented on a diff in the pull request: https://github.com/apache/incubator-tinkerpop/pull/223#discussion_r52587408 — Diff: docs/src/upgrade/release-3.1.x-incubating.asciidoc — @@ -22,6 +22,32 @@ image:: https://raw.githubusercontent.com/apache/incubator-tinkerpop/master/docs/ A 187 On The Undercover Gremlinz +TinkerPop 3.1.2 +--------------- + + Release Date: NOT OFFICIALLY RELEASED YET + +Please see the link: https://github.com/apache/incubator-tinkerpop/blob/3.1.1-incubating/CHANGELOG.asciidoc#tinkerpop-312-release-date-XXXXXXXXXXXXXXXXXXXXXXXXXX[changelog ] for a complete list of all the modifications that are part of this release. + +Upgrading for Providers +~~~~~~~~~~~~~~~~~~~~~~~ + +IMPORTANT: It is recommended that providers also review all the upgrade instructions specified for users. Many of the +changes there may prove important for the provider's implementation. + +Graph System Providers +^^^^^^^^^^^^^^^^^^^^^^ + +GraphProvider.clear() Semantics ++++++++++++++++++++++++++++++++ + +The semantics of the various `clear()` methods on `GraphProvider` didn't really change, but it would be worth reviewing +their implementations to ensure that implementations can be called successfully in an idempotent fashion. Multiple +calls to `clear()` may occur for a single test on the same `Graph` instance, as `3.1.1-incubating` introduced an — End diff – It should be as-is - that feature came in at that version, but came with the described limitation
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user okram commented on the pull request:

        https://github.com/apache/incubator-tinkerpop/pull/223#issuecomment-182811682

        VOTE +1. I will be so happy to see the "randomness" removed from our integration testing. Thanks @spmallette.

        Show
        githubbot ASF GitHub Bot added a comment - Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/223#issuecomment-182811682 VOTE +1. I will be so happy to see the "randomness" removed from our integration testing. Thanks @spmallette.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user twilmes commented on a diff in the pull request:

        https://github.com/apache/incubator-tinkerpop/pull/223#discussion_r52563479

        — Diff: docs/src/upgrade/release-3.1.x-incubating.asciidoc —
        @@ -22,6 +22,32 @@ image::https://raw.githubusercontent.com/apache/incubator-tinkerpop/master/docs/

        A 187 On The Undercover Gremlinz

        +TinkerPop 3.1.2
        +---------------
        +
        +Release Date: NOT OFFICIALLY RELEASED YET
        +
        +Please see the link:https://github.com/apache/incubator-tinkerpop/blob/3.1.1-incubating/CHANGELOG.asciidoc#tinkerpop-312-release-date-XXXXXXXXXXXXXXXXXXXXXXXXXX[changelog] for a complete list of all the modifications that are part of this release.
        +
        +Upgrading for Providers
        +~~~~~~~~~~~~~~~~~~~~~~~
        +
        +IMPORTANT: It is recommended that providers also review all the upgrade instructions specified for users. Many of the
        +changes there may prove important for the provider's implementation.
        +
        +Graph System Providers
        +^^^^^^^^^^^^^^^^^^^^^^
        +
        +GraphProvider.clear() Semantics
        ++++++++++++++++++++++++++++++++
        +
        +The semantics of the various `clear()` methods on `GraphProvider` didn't really change, but it would be worth reviewing
        +their implementations to ensure that implementations can be called successfully in an idempotent fashion. Multiple
        +calls to `clear()` may occur for a single test on the same `Graph` instance, as `3.1.1-incubating` introduced an
        — End diff –

        Should `3.1.1-incubating` be `3.1.2-incubating` here?

        Show
        githubbot ASF GitHub Bot added a comment - Github user twilmes commented on a diff in the pull request: https://github.com/apache/incubator-tinkerpop/pull/223#discussion_r52563479 — Diff: docs/src/upgrade/release-3.1.x-incubating.asciidoc — @@ -22,6 +22,32 @@ image:: https://raw.githubusercontent.com/apache/incubator-tinkerpop/master/docs/ A 187 On The Undercover Gremlinz +TinkerPop 3.1.2 +--------------- + + Release Date: NOT OFFICIALLY RELEASED YET + +Please see the link: https://github.com/apache/incubator-tinkerpop/blob/3.1.1-incubating/CHANGELOG.asciidoc#tinkerpop-312-release-date-XXXXXXXXXXXXXXXXXXXXXXXXXX[changelog ] for a complete list of all the modifications that are part of this release. + +Upgrading for Providers +~~~~~~~~~~~~~~~~~~~~~~~ + +IMPORTANT: It is recommended that providers also review all the upgrade instructions specified for users. Many of the +changes there may prove important for the provider's implementation. + +Graph System Providers +^^^^^^^^^^^^^^^^^^^^^^ + +GraphProvider.clear() Semantics ++++++++++++++++++++++++++++++++ + +The semantics of the various `clear()` methods on `GraphProvider` didn't really change, but it would be worth reviewing +their implementations to ensure that implementations can be called successfully in an idempotent fashion. Multiple +calls to `clear()` may occur for a single test on the same `Graph` instance, as `3.1.1-incubating` introduced an — End diff – Should `3.1.1-incubating` be `3.1.2-incubating` here?
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user spmallette opened a pull request:

        https://github.com/apache/incubator-tinkerpop/pull/223

        TINKERPOP-1146 Use GraphProvider.clear() to auto-clear graphs created in tests

        https://issues.apache.org/jira/browse/TINKERPOP-1146

        Was formerly just calling `Graph.close()` which wasn't enough to actually empty graphs of data. This led to test errors for some graph providers. This change actually calls `GraphProvider.clear()` which by definition should empty a graph of data at the end of a test.

        To test you technically need a graph that is persistent (e.g. Neo4j). Ran `mvn clean install -DincludeNeo4j` without problems.

        VOTE +1

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP-1146

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/incubator-tinkerpop/pull/223.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #223


        commit 597c350459cf0ade1791180b0660d415064e17c4
        Author: Stephen Mallette <spmva@genoprime.com>
        Date: 2016-02-10T19:51:20Z

        Use GraphProvider.clear() to auto-clear graphs created in tests

        Was formerlly just calling Graph.close() which wasn't enough to actually empty graphs of data. This led to test errors for some graph providers. This change actually calls GraphProvider.clear() which by definition should empty a graph of data at the end of a test.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user spmallette opened a pull request: https://github.com/apache/incubator-tinkerpop/pull/223 TINKERPOP-1146 Use GraphProvider.clear() to auto-clear graphs created in tests https://issues.apache.org/jira/browse/TINKERPOP-1146 Was formerly just calling `Graph.close()` which wasn't enough to actually empty graphs of data. This led to test errors for some graph providers. This change actually calls `GraphProvider.clear()` which by definition should empty a graph of data at the end of a test. To test you technically need a graph that is persistent (e.g. Neo4j). Ran `mvn clean install -DincludeNeo4j` without problems. VOTE +1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP-1146 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-tinkerpop/pull/223.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #223 commit 597c350459cf0ade1791180b0660d415064e17c4 Author: Stephen Mallette <spmva@genoprime.com> Date: 2016-02-10T19:51:20Z Use GraphProvider.clear() to auto-clear graphs created in tests Was formerlly just calling Graph.close() which wasn't enough to actually empty graphs of data. This led to test errors for some graph providers. This change actually calls GraphProvider.clear() which by definition should empty a graph of data at the end of a test.
        Hide
        spmallette stephen mallette added a comment -

        Actually - I think I sorta know what's going on. This is a bug in the test infrastructure. It could be directly fixed by calling clear() at the end of each test, but you shouldn't have to do that because we have infrastructure now that closes all opened graph at the end of a test - but apparently that's not fully cleaning up. damn - providers who see problems with that test will have to optout..... :/

        Show
        spmallette stephen mallette added a comment - Actually - I think I sorta know what's going on. This is a bug in the test infrastructure. It could be directly fixed by calling clear() at the end of each test, but you shouldn't have to do that because we have infrastructure now that closes all opened graph at the end of a test - but apparently that's not fully cleaning up. damn - providers who see problems with that test will have to optout..... :/
        Hide
        spmallette stephen mallette added a comment -

        Do you know why neo4j doesn't have problems? or rather, under what circumstances does neo4j have problems with this (because I used to see errors with these tests in other environments - never mine)?

        Show
        spmallette stephen mallette added a comment - Do you know why neo4j doesn't have problems? or rather, under what circumstances does neo4j have problems with this (because I used to see errors with these tests in other environments - never mine)?

          People

          • Assignee:
            spmallette stephen mallette
            Reporter:
            pietermartin pieter martin
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development