Uploaded image for project: 'TinkerPop'
  1. TinkerPop
  2. TINKERPOP-1142

Remove deprecated valueIncr, valueDecr, keyIncr, keyDecr.

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.2.0-incubating
    • Fix Version/s: 3.3.0
    • Component/s: process
    • Labels:

      Issue Links

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user okram opened a pull request:

        https://github.com/apache/tinkerpop/pull/660

        TINKERPOP-1142: Remove deprecated valueIncr, valueDecr, keyIncr, keyDecr.

        https://issues.apache.org/jira/browse/TINKERPOP-1142

        Removed deprecated `valueIncr`, `valueDecr`, `keyIncr`, and `keyDecr`. These were deprecated long ago and replaced with `Column.values` and `Column.keys` along with the use of `Order.incr` and `Order.decr` accordingly.

        VOTE +1

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/apache/tinkerpop TINKERPOP-1142

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tinkerpop/pull/660.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #660


        commit ae100b3083e9a9d5b323b47ea11d31c1f1e5b92a
        Author: Marko A. Rodriguez <okrammarko@gmail.com>
        Date: 2017-07-10T14:54:52Z

        removed deprecated Order enums keyDecr, valueDecr, keyIncr, and valueIncr. These were replaced long ago by Column.keys and Column.values using respective Order.incr and Order.decr ordering enums.

        commit 8cf3173b8a519af62e8a4621daf89f0a8412d7ed
        Author: Marko A. Rodriguez <okrammarko@gmail.com>
        Date: 2017-07-10T14:57:01Z

        removed valueIncr, valueDecr, keyIncr, and keyDecr from Gremlin-Python enums.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user okram opened a pull request: https://github.com/apache/tinkerpop/pull/660 TINKERPOP-1142 : Remove deprecated valueIncr, valueDecr, keyIncr, keyDecr. https://issues.apache.org/jira/browse/TINKERPOP-1142 Removed deprecated `valueIncr`, `valueDecr`, `keyIncr`, and `keyDecr`. These were deprecated long ago and replaced with `Column.values` and `Column.keys` along with the use of `Order.incr` and `Order.decr` accordingly. VOTE +1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/tinkerpop TINKERPOP-1142 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/660.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #660 commit ae100b3083e9a9d5b323b47ea11d31c1f1e5b92a Author: Marko A. Rodriguez <okrammarko@gmail.com> Date: 2017-07-10T14:54:52Z removed deprecated Order enums keyDecr, valueDecr, keyIncr, and valueIncr. These were replaced long ago by Column.keys and Column.values using respective Order.incr and Order.decr ordering enums. commit 8cf3173b8a519af62e8a4621daf89f0a8412d7ed Author: Marko A. Rodriguez <okrammarko@gmail.com> Date: 2017-07-10T14:57:01Z removed valueIncr, valueDecr, keyIncr, and keyDecr from Gremlin-Python enums.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user spmallette commented on the issue:

        https://github.com/apache/tinkerpop/pull/660

        All tests pass with docker/build.sh -t -n -i

        VOTE +1 (with the assumption that the JIRA ticket will get added to upgrade docs after merge)

        Show
        githubbot ASF GitHub Bot added a comment - Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/660 All tests pass with docker/build.sh -t -n -i VOTE +1 (with the assumption that the JIRA ticket will get added to upgrade docs after merge)
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user dkuppitz commented on the issue:

        https://github.com/apache/tinkerpop/pull/660

        VOTE: +1

        Show
        githubbot ASF GitHub Bot added a comment - Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/660 VOTE: +1
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tinkerpop/pull/660

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/660

          People

          • Assignee:
            okram Marko A. Rodriguez
            Reporter:
            okram Marko A. Rodriguez
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development