Details
-
Type:
Improvement
-
Status: Closed
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: 3.2.0-incubating, 3.1.2-incubating
-
Component/s: process
-
Labels:None
Description
Provide a method that allows to explicitly set an edge id.
Edge edge(final Vertex outV, final Vertex inV, final Object edgeId, final String label);
Activity
- All
- Comments
- Work Log
- History
- Activity
- Transitions
Github user okram commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/220#issuecomment-182606650
This is looking much better. Given that this is backwards compatible (nice Exception catching trick BTW), can you make at least one of the script.groovy in the old model so we know that backwards compatibility with Deprecated ScriptElementFactory is preserved. When we ultimately drop ScriptElementFactory, we then fix up the old script.groovy.
Github user dkuppitz commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/220#issuecomment-182614201
Reverted the changes in `grateful-dead-script-input.groovy`, so it's using the old model. `script-input.groovy` uses the new model. Both scripts are used in unit tests, thus each case is covered.
Github user okram commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/220#issuecomment-182629585
VOTE +1.
Github user twilmes commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/220#issuecomment-182709226
Looks good
VOTE +1
Github user asfgit closed the pull request at:
re-opening to add 3.2.0-incubating to fix version
Github user dkuppitz commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/220#issuecomment-182604992
VOTE: +1