Uploaded image for project: 'TinkerPop'
  1. TinkerPop
  2. TINKERPOP-1137

Deprecate ScriptElementFactory and make star graph globally available

    Details

      Description

      Provide a method that allows to explicitly set an edge id.

      Edge edge(final Vertex outV, final Vertex inV, final Object edgeId, final String label);
      

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user dkuppitz commented on the pull request:

        https://github.com/apache/incubator-tinkerpop/pull/220#issuecomment-182604992

        • `mvn clean install`: passed
        • `bin/process-docs.sh`: passed
        • integration tests: passed

        VOTE: +1

        Show
        githubbot ASF GitHub Bot added a comment - Github user dkuppitz commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/220#issuecomment-182604992 `mvn clean install`: passed `bin/process-docs.sh`: passed integration tests: passed VOTE: +1
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user okram commented on the pull request:

        https://github.com/apache/incubator-tinkerpop/pull/220#issuecomment-182606650

        This is looking much better. Given that this is backwards compatible (nice Exception catching trick BTW), can you make at least one of the script.groovy in the old model so we know that backwards compatibility with Deprecated ScriptElementFactory is preserved. When we ultimately drop ScriptElementFactory, we then fix up the old script.groovy.

        Show
        githubbot ASF GitHub Bot added a comment - Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/220#issuecomment-182606650 This is looking much better. Given that this is backwards compatible (nice Exception catching trick BTW), can you make at least one of the script.groovy in the old model so we know that backwards compatibility with Deprecated ScriptElementFactory is preserved. When we ultimately drop ScriptElementFactory, we then fix up the old script.groovy.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user dkuppitz commented on the pull request:

        https://github.com/apache/incubator-tinkerpop/pull/220#issuecomment-182614201

        Reverted the changes in `grateful-dead-script-input.groovy`, so it's using the old model. `script-input.groovy` uses the new model. Both scripts are used in unit tests, thus each case is covered.

        Show
        githubbot ASF GitHub Bot added a comment - Github user dkuppitz commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/220#issuecomment-182614201 Reverted the changes in `grateful-dead-script-input.groovy`, so it's using the old model. `script-input.groovy` uses the new model. Both scripts are used in unit tests, thus each case is covered.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user okram commented on the pull request:

        https://github.com/apache/incubator-tinkerpop/pull/220#issuecomment-182629585

        VOTE +1.

        Show
        githubbot ASF GitHub Bot added a comment - Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/220#issuecomment-182629585 VOTE +1.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user twilmes commented on the pull request:

        https://github.com/apache/incubator-tinkerpop/pull/220#issuecomment-182709226

        Looks good
        VOTE +1

        Show
        githubbot ASF GitHub Bot added a comment - Github user twilmes commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/220#issuecomment-182709226 Looks good VOTE +1
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/incubator-tinkerpop/pull/220

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/incubator-tinkerpop/pull/220
        Hide
        spmallette stephen mallette added a comment -

        re-opening to add 3.2.0-incubating to fix version

        Show
        spmallette stephen mallette added a comment - re-opening to add 3.2.0-incubating to fix version

          People

          • Assignee:
            dkuppitz Daniel Kuppitz
            Reporter:
            dkuppitz Daniel Kuppitz
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development