Uploaded image for project: 'TinkerPop'
  1. TinkerPop
  2. TINKERPOP-1064

Allow a ClassResolver to be added to GryoMapper construction

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Implemented
    • Affects Version/s: 3.1.0-incubating
    • Fix Version/s: 3.1.1-incubating
    • Component/s: io
    • Labels:
      None

      Description

      Allowing a ClassResolver to be applied in the GryoMapper will provide a final degree of flexibility for plugging in custom functionality to a Kryo instance.

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user spmallette opened a pull request:

        https://github.com/apache/incubator-tinkerpop/pull/189

        TINKERPOP-1064 Allow a ClassResolver to be added to GryoMapper construction

        https://issues.apache.org/jira/browse/TINKERPOP-1064

        Not much to say here - This change just allows for some deep customization to the creation of the `GryoMapper`. Tested with:

        ```text
        mvn clean install && mvn verify -DskipIntegrationTests=false -DincludeNeo4j
        ```

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP-1064

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/incubator-tinkerpop/pull/189.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #189


        commit a94c51f368f91a7c1204fb19517d02338ca1b141
        Author: Stephen Mallette <spmva@genoprime.com>
        Date: 2015-12-24T11:54:11Z

        Add option on GryoMapper to allow overriding the ClassResolver.

        Included tests to demonstrate capabilities.

        commit a51701d907539328d8a486cfb4f03e7ef5082554
        Author: Stephen Mallette <spmva@genoprime.com>
        Date: 2015-12-24T12:00:12Z

        Removed test IoRegistry implementations for ClassResolver.

        Apparently, it is unnecessary to register a serializer to a class whose registration is overriden by the ClassResolver. That's kinda cool.

        commit 5c196db6fde877abfdb4c1d07049fe8cf8d16bb8
        Author: Stephen Mallette <spmva@genoprime.com>
        Date: 2015-12-24T12:59:46Z

        Enable the message serializers to use the ClassResolver setting.

        This will allow Gremlin Server to get configured with the custom ClassResolver instance.

        commit c288d658438008e3e5a66efe7ed39a2444552d9e
        Author: Stephen Mallette <spmva@genoprime.com>
        Date: 2015-12-24T13:01:16Z

        Updated changelog.

        commit 34db89216dfda92e8dbe1389feb8dc8690c088ba
        Author: Stephen Mallette <spmva@genoprime.com>
        Date: 2015-12-24T13:30:22Z

        Update reference docs.

        commit 0defd91a992e1abbbefc1519871f501bc17a4711
        Author: Stephen Mallette <spmva@genoprime.com>
        Date: 2015-12-24T13:30:35Z

        Update upgrade docs.

        commit e480f4aa9ac419443b54df3ccc9bc538dfeffe28
        Author: Stephen Mallette <spmva@genoprime.com>
        Date: 2015-12-29T23:45:19Z

        Merge remote-tracking branch 'origin/master' into TINKERPOP-1064


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user spmallette opened a pull request: https://github.com/apache/incubator-tinkerpop/pull/189 TINKERPOP-1064 Allow a ClassResolver to be added to GryoMapper construction https://issues.apache.org/jira/browse/TINKERPOP-1064 Not much to say here - This change just allows for some deep customization to the creation of the `GryoMapper`. Tested with: ```text mvn clean install && mvn verify -DskipIntegrationTests=false -DincludeNeo4j ``` You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP-1064 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-tinkerpop/pull/189.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #189 commit a94c51f368f91a7c1204fb19517d02338ca1b141 Author: Stephen Mallette <spmva@genoprime.com> Date: 2015-12-24T11:54:11Z Add option on GryoMapper to allow overriding the ClassResolver. Included tests to demonstrate capabilities. commit a51701d907539328d8a486cfb4f03e7ef5082554 Author: Stephen Mallette <spmva@genoprime.com> Date: 2015-12-24T12:00:12Z Removed test IoRegistry implementations for ClassResolver. Apparently, it is unnecessary to register a serializer to a class whose registration is overriden by the ClassResolver. That's kinda cool. commit 5c196db6fde877abfdb4c1d07049fe8cf8d16bb8 Author: Stephen Mallette <spmva@genoprime.com> Date: 2015-12-24T12:59:46Z Enable the message serializers to use the ClassResolver setting. This will allow Gremlin Server to get configured with the custom ClassResolver instance. commit c288d658438008e3e5a66efe7ed39a2444552d9e Author: Stephen Mallette <spmva@genoprime.com> Date: 2015-12-24T13:01:16Z Updated changelog. commit 34db89216dfda92e8dbe1389feb8dc8690c088ba Author: Stephen Mallette <spmva@genoprime.com> Date: 2015-12-24T13:30:22Z Update reference docs. commit 0defd91a992e1abbbefc1519871f501bc17a4711 Author: Stephen Mallette <spmva@genoprime.com> Date: 2015-12-24T13:30:35Z Update upgrade docs. commit e480f4aa9ac419443b54df3ccc9bc538dfeffe28 Author: Stephen Mallette <spmva@genoprime.com> Date: 2015-12-29T23:45:19Z Merge remote-tracking branch 'origin/master' into TINKERPOP-1064
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user spmallette commented on the pull request:

        https://github.com/apache/incubator-tinkerpop/pull/189#issuecomment-168042654

        Going to amend this PR with changes from https://issues.apache.org/jira/browse/TINKERPOP-1066 - as these changes are all sort of related.

        Show
        githubbot ASF GitHub Bot added a comment - Github user spmallette commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/189#issuecomment-168042654 Going to amend this PR with changes from https://issues.apache.org/jira/browse/TINKERPOP-1066 - as these changes are all sort of related.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user spmallette commented on the pull request:

        https://github.com/apache/incubator-tinkerpop/pull/189#issuecomment-168059823

        VOTE +1 - note that this PR covers both: TINKERPOP-1064 and TINKERPOP-1066.

        Show
        githubbot ASF GitHub Bot added a comment - Github user spmallette commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/189#issuecomment-168059823 VOTE +1 - note that this PR covers both: TINKERPOP-1064 and TINKERPOP-1066 .
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user okram commented on the pull request:

        https://github.com/apache/incubator-tinkerpop/pull/189#issuecomment-168749340

        `mvn clean install` passed. VOTE +1.

        Show
        githubbot ASF GitHub Bot added a comment - Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/189#issuecomment-168749340 `mvn clean install` passed. VOTE +1.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user dkuppitz commented on the pull request:

        https://github.com/apache/incubator-tinkerpop/pull/189#issuecomment-168793778

        Full integration test suite also passed.

        VOTE: +1

        Show
        githubbot ASF GitHub Bot added a comment - Github user dkuppitz commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/189#issuecomment-168793778 Full integration test suite also passed. VOTE: +1
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/incubator-tinkerpop/pull/189

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/incubator-tinkerpop/pull/189

          People

          • Assignee:
            spmallette stephen mallette
            Reporter:
            spmallette stephen mallette
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development