Uploaded image for project: 'TinkerPop'
  1. TinkerPop
  2. TINKERPOP-1039

Enable auto-commit for session'd requests.

    Details

      Description

      Context: Regular (non-session) requests automatically handle transaction commit/rollback. Session'd requests do not.

      As a gremlin server user, I would like the ability to enable automatic transaction handling for session's requests. I would be fine w/ either of the following:

      • Configuring my Client to be auto-commit at startup time
      • Specifying a "autoCommit: true" arg when submitting a RequestMessage

        Activity

        Hide
        spmallette stephen mallette added a comment -

        I think this might be best kept for 3.1.2 or 3.2.x - it seems to involve bigger changes than i'd expected initially and code freeze date is looming.

        Show
        spmallette stephen mallette added a comment - I think this might be best kept for 3.1.2 or 3.2.x - it seems to involve bigger changes than i'd expected initially and code freeze date is looming.
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user spmallette opened a pull request:

        https://github.com/apache/incubator-tinkerpop/pull/224

        TINKERPOP-1039 Allowed for transaction management in sessions.

        https://issues.apache.org/jira/browse/TINKERPOP-1039

        Added a per request argument called manageTransaction to allow an in-session client to signal that it would like Gremlin Server to commit/rollback at the end of the request. This basically allows a session to behave much like the sessionless request does by default.

        Did a `--dryRun` of the docs for quick review and `mvn clean install && mvn verify -pl gremlin-server -DskipIntegrationTests=false -DincludeNeo4j` and all looked good.

        @PommeVerte this one might be of interest to you for review.

        VOTE +1

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP-1039

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/incubator-tinkerpop/pull/224.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #224


        commit e9966b3bdbbf8ca34a45e6f9f7a48e9b8b2d5720
        Author: Stephen Mallette <spmva@genoprime.com>
        Date: 2016-02-11T17:10:37Z

        Allowed for transaction management in sessions.

        Added a per request argument called manageTransaction to allow an in-session client to signal that it would like Gremlin Server to commit/rollback at the end of the request. This basically allows a session to behave much like the sessionless request does by default.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user spmallette opened a pull request: https://github.com/apache/incubator-tinkerpop/pull/224 TINKERPOP-1039 Allowed for transaction management in sessions. https://issues.apache.org/jira/browse/TINKERPOP-1039 Added a per request argument called manageTransaction to allow an in-session client to signal that it would like Gremlin Server to commit/rollback at the end of the request. This basically allows a session to behave much like the sessionless request does by default. Did a `--dryRun` of the docs for quick review and `mvn clean install && mvn verify -pl gremlin-server -DskipIntegrationTests=false -DincludeNeo4j` and all looked good. @PommeVerte this one might be of interest to you for review. VOTE +1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP-1039 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-tinkerpop/pull/224.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #224 commit e9966b3bdbbf8ca34a45e6f9f7a48e9b8b2d5720 Author: Stephen Mallette <spmva@genoprime.com> Date: 2016-02-11T17:10:37Z Allowed for transaction management in sessions. Added a per request argument called manageTransaction to allow an in-session client to signal that it would like Gremlin Server to commit/rollback at the end of the request. This basically allows a session to behave much like the sessionless request does by default.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user dkuppitz commented on the pull request:

        https://github.com/apache/incubator-tinkerpop/pull/224#issuecomment-183353783

        • `mvn clean install`: passed
        • integration tests: passed

        Wonderful addition.

        VOTE: +1

        Show
        githubbot ASF GitHub Bot added a comment - Github user dkuppitz commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/224#issuecomment-183353783 `mvn clean install`: passed integration tests: passed Wonderful addition. VOTE: +1
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user okram commented on the pull request:

        https://github.com/apache/incubator-tinkerpop/pull/224#issuecomment-183509058

        VOTE +1.

        Show
        githubbot ASF GitHub Bot added a comment - Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/224#issuecomment-183509058 VOTE +1.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/incubator-tinkerpop/pull/224

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/incubator-tinkerpop/pull/224
        Hide
        spmallette stephen mallette added a comment -

        re-opening to add 3.2.0-incubating to fix version

        Show
        spmallette stephen mallette added a comment - re-opening to add 3.2.0-incubating to fix version

          People

          • Assignee:
            spmallette stephen mallette
            Reporter:
            rjbriody Bob Briody
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development