Uploaded image for project: 'TinkerPop'
  1. TinkerPop
  2. TINKERPOP-1004

Make Transaction.commit() failures consistent across implementations.

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: 3.0.2-incubating
    • Fix Version/s: 3.3.0
    • Component/s: structure
    • Labels:

      Description

      Currently commit() can fail when implementations throw exceptions. These exceptions aren't consistent and are very implementation specific. It would be good to abstract this and provide TP specific exceptions for this (while bubbling the original exceptions).

        Issue Links

          Activity

          Hide
          dmill Dylan Millikin added a comment - - edited

          a couple of points that would make this worth it:
          https://issues.apache.org/jira/browse/TINKERPOP3-1005

          and the following thread might shed some light: https://lists.apache.org/thread.html/Zhvzunq4kw26ysm

          Show
          dmill Dylan Millikin added a comment - - edited a couple of points that would make this worth it: https://issues.apache.org/jira/browse/TINKERPOP3-1005 and the following thread might shed some light: https://lists.apache.org/thread.html/Zhvzunq4kw26ysm
          Show
          dmill Dylan Millikin added a comment - Some nice links pieter posted in that thread: http://docs.oracle.com/javaee/6/api/javax/transaction/package-summary.html http://docs.oracle.com/javaee/6/api/index.html?javax/transaction/UserTransaction.html
          Hide
          spmallette stephen mallette added a comment -

          Sent a message to the dev list to propose a simple method for solving this. Basically uses stuff we already have in place - https://lists.apache.org/thread.html/12cedcd8400318d9cc1d6dbbb78ff94e0834f84c4881345a15e35f32@%3Cdev.tinkerpop.apache.org%3E

          Show
          spmallette stephen mallette added a comment - Sent a message to the dev list to propose a simple method for solving this. Basically uses stuff we already have in place - https://lists.apache.org/thread.html/12cedcd8400318d9cc1d6dbbb78ff94e0834f84c4881345a15e35f32@%3Cdev.tinkerpop.apache.org%3E
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user spmallette opened a pull request:

          https://github.com/apache/tinkerpop/pull/637

          TINKERPOP-1004 Expand usage of TransactionException

          https://issues.apache.org/jira/browse/TINKERPOP-1004

          `TransactionException` is no longer bound to usage by `AbstractTransaction`. Prescribed a more general usage of it with the Transaction interface.

          Builds with `mvn clean install -DincludeNeo4j && mvn verify -pl gremlin-server -DskipIntegrationTests=false -DincludeNeo4j`

          VOTE +1

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/apache/tinkerpop TINKERPOP-1004

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/tinkerpop/pull/637.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #637


          commit eb0eddca04050cb48d1262c7ff3bc28354f558c6
          Author: Stephen Mallette <spmva@genoprime.com>
          Date: 2017-06-20T16:57:04Z

          TINKERPOP-1004 Expand usage of TransactionException

          TransactionException is no longer bound to usage by AbstractTransaction. Precribed a more general usage of it with the Transaction interface.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user spmallette opened a pull request: https://github.com/apache/tinkerpop/pull/637 TINKERPOP-1004 Expand usage of TransactionException https://issues.apache.org/jira/browse/TINKERPOP-1004 `TransactionException` is no longer bound to usage by `AbstractTransaction`. Prescribed a more general usage of it with the Transaction interface. Builds with `mvn clean install -DincludeNeo4j && mvn verify -pl gremlin-server -DskipIntegrationTests=false -DincludeNeo4j` VOTE +1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/tinkerpop TINKERPOP-1004 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/637.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #637 commit eb0eddca04050cb48d1262c7ff3bc28354f558c6 Author: Stephen Mallette <spmva@genoprime.com> Date: 2017-06-20T16:57:04Z TINKERPOP-1004 Expand usage of TransactionException TransactionException is no longer bound to usage by AbstractTransaction. Precribed a more general usage of it with the Transaction interface.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user dkuppitz commented on the issue:

          https://github.com/apache/tinkerpop/pull/637

          VOTE: +1

          Show
          githubbot ASF GitHub Bot added a comment - Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/637 VOTE: +1
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user okram commented on the issue:

          https://github.com/apache/tinkerpop/pull/637

          VOTE +1

          Show
          githubbot ASF GitHub Bot added a comment - Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/637 VOTE +1
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/tinkerpop/pull/637

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/637

            People

            • Assignee:
              spmallette stephen mallette
              Reporter:
              dmill Dylan Millikin
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development