[TILES-575] Definition loading from Resolvers inconsistent

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Invalid
• Affects Version/s: 3.0.3
• Fix Version/s: 3.0.3
• Component/s: tiles-core
• Labels: patch
• Assignee: Unassigned
• Reporter: Eric B
• Created: 11/Nov/13 20:34
• Updated: 11/Nov/13 20:39
• Resolved: 11/Nov/13 20:39

Description

When definitions are initially loaded from tiles.xml, exact string matches take precedence over anything resolved by a Resolver (Pattern, etc). However, once a definition has been resolved by the resolver, it is cached in the same definitions hashmap as the exact strings, and any implied precedence is lost.

Essentially, the first time a definition is resolved, Tiles applies a specific precedence, but subsequent resolutions do not resolve following the same rules.

This can be seen in CachingLocaleUrlDefinitionDAO.getDefinition():

        Map<String, Definition> definitions = getDefinitions(customizationKey);
        if (definitions != null) {
            retValue = definitions.get(name);

            if (retValue == null) {
                retValue = getDefinitionFromResolver(name, customizationKey);

                if (retValue != null) {
                    synchronized (definitions) {
                        definitions.put(name, retValue);
                    }
                }
            }
        }

The first time the definition is resolved using definitions.get(name), it does an exact string match. Otherwise subsen