Uploaded image for project: 'Tiles'
  1. Tiles
  2. TILES-374

change visibility of 'render' methods in BasicTilesContainer

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Trivial
    • Resolution: Fixed
    • 2.1.2
    • 2.1.3
    • tiles-core
    • None

    Description

      Extending BasicTilesContainer is limited due to many private methods. I'd like to add declarative caching in my tiles definition file (by adding an attribute 'cache' with value 'cacheKey') to skip rendering of a definition and pull entire content from the cache. Actually the only place I can do that is BasicTilesContainer.render(TilesRequestContext request, String definitionName) method. Within this method, definition is being loaded (hence, attributes are available) and check against possible cache would be possible. Unfortunately this and following 'render' methods are private, and I can't override appropriate methods. Can you consider changing visibility to protected or providing some hooks in definition rendering flow.

      Attachments

        1. TILES-374.patch
          2 kB
          pijmleko

        Activity

          People

            brenmcguire Antonio Petrelli
            pijmleko pijmleko
            Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: