Uploaded image for project: 'Tiles'
  1. Tiles
  2. TILES-305

NPE in InsertAttributeTag when using ignore flag

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 2.1.0
    • 2.1.1
    • None
    • Patch

    Description

      Current implementation of InsertAttributeTag throws NPE if there is no such attribute and ignore flag is set to true. GetAsStringTag implies not-null attribute while InsertAttributeTag from which it is derived misses check of ignore flag before rendering. Need to add simple check in InsertAttributeTag.render() like it was in tiles-2.0.5:
      if (attr == null && ignore) {
      return;
      }

      Attachments

        1. InsertAttributeTag.patch
          0.5 kB
          Oleg Gorobets

        Activity

          People

            brenmcguire Antonio Petrelli
            barabaka Oleg Gorobets
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: