[TIKA-791] Fix the detection of protected OOXML files

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.1
• Fix Version/s: 1.1
• Component/s: mime

Environment

Windows 7 64 bit

• Assignee: Unassigned
• Reporter: Antoni Mylka
• Created: 25/Nov/11 15:46
• Updated: 14/Dec/11 13:23
• Resolved: 14/Dec/11 13:23

Description

TIKA-437 patch allowed Tika to work with OOXML files protected with the default VelvetSweatshop password. I feel there is room for improvement.

1. The POIFSContainerDetector lies when it sees such a file. It should be able to mark it as x-tika-ooxml
2. The OOXMLParser can't work with such a file. It should:
   1. If it's protected with the default password - it should be decrypted and processed normally.
   2. If it's protected with a non-default password - the file should be marked as protected, no weird exceptions should appear.

Therefore I'd like to add an 'if' to POIFSContainerDetector which returns x-tika-ooxml, and some code to OOXMLParser, which would be similar to the code currently residing in OfficeParser. After this improvement both the OfficeParser and the OOXMLParser will treat such files in the same way.

When I have that, I can add a hack in my application, which will say "If the type is x-tika-ooxml and the name-based detection is a specialization of ooxml, then use the name-based detection". This will be a workaround for the fact that in MimeTypes, magic always trumps the name. With that, the encrypted DOCX files will appear with the normal DOCX mimetype in my app.