[TIKA-662] Prevent creating of ZipInputStreamZipEntrySource when reading files from disk

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.10
• Assignee: Unassigned
• Reporter: Maxim Valyanskiy
• Created: 18/May/11 13:57
• Updated: 20/Oct/11 12:34
• Resolved: 19/May/11 07:52

Description

POI provides two ways to open OPCPackage - via InputStream and via File. Creating OPCPackage from InputStream casuses creation of ZipInputStreamZipEntrySource, that buffers all uncompressed data in memory. This takes a lot of memory and it is not needed when we are reading files from disk or when we already copied stream into temporary file.

This patch removes usage of ZipInputStreamZipEntrySource in this case.

Unfortunately, it breaks ZIP-bomb prevention for OOXML parser (and other parsers that uses TikaInputStream.getFile()). I think that ZIP-bomb prevention should be additionally implemented for that formats before committing this to SVN.