Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.13
    • Fix Version/s: 2.0, 1.14
    • Component/s: parser
    • Labels:
      None
    • Environment:

      Win7, jre1.8.0_101 x64

      Description

      When parsing the attached corrupted CHM, ChmParser leaks memory and causes the app to hang (collecting garbage) and throw OOM errors.

      1. 115212s.chm
        4 kB
        Luis Filipe Nassif

        Activity

        Hide
        lfcnassif Luis Filipe Nassif added a comment -

        Problematic file

        Show
        lfcnassif Luis Filipe Nassif added a comment - Problematic file
        Hide
        tallison@mitre.org Tim Allison added a comment -

        Thank you, Luis Filipe Nassif!

        Show
        tallison@mitre.org Tim Allison added a comment - Thank you, Luis Filipe Nassif !
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in tika-2.x-windows #30 (See https://builds.apache.org/job/tika-2.x-windows/30/)
        TIKA-2040 - prevent permanent hang/oom on corrupt chm file (tallison: rev 1c582aba6b97e2579a3f468bc24ebfa3971663c2)

        • tika-parser-modules/tika-parser-office-module/src/main/java/org/apache/tika/parser/chm/lzx/ChmLzxBlock.java
        • tika-parser-modules/tika-parser-office-module/src/main/java/org/apache/tika/parser/chm/core/ChmCommons.java
        • tika-test-resources/src/test/resources/test-documents/testChm_oom.chm
        • tika-parser-modules/tika-parser-office-module/src/test/java/org/apache/tika/parser/chm/TestChmExtractor.java
        • tika-parser-modules/tika-parser-office-module/src/main/java/org/apache/tika/parser/chm/accessor/ChmDirectoryListingSet.java
        • tika-parser-modules/tika-parser-office-module/src/main/java/org/apache/tika/parser/chm/core/ChmExtractor.java
        • CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in tika-2.x-windows #30 (See https://builds.apache.org/job/tika-2.x-windows/30/ ) TIKA-2040 - prevent permanent hang/oom on corrupt chm file (tallison: rev 1c582aba6b97e2579a3f468bc24ebfa3971663c2) tika-parser-modules/tika-parser-office-module/src/main/java/org/apache/tika/parser/chm/lzx/ChmLzxBlock.java tika-parser-modules/tika-parser-office-module/src/main/java/org/apache/tika/parser/chm/core/ChmCommons.java tika-test-resources/src/test/resources/test-documents/testChm_oom.chm tika-parser-modules/tika-parser-office-module/src/test/java/org/apache/tika/parser/chm/TestChmExtractor.java tika-parser-modules/tika-parser-office-module/src/main/java/org/apache/tika/parser/chm/accessor/ChmDirectoryListingSet.java tika-parser-modules/tika-parser-office-module/src/main/java/org/apache/tika/parser/chm/core/ChmExtractor.java CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in tika-2.x #126 (See https://builds.apache.org/job/tika-2.x/126/)
        TIKA-2040 - prevent permanent hang/oom on corrupt chm file (tallison: rev 1c582aba6b97e2579a3f468bc24ebfa3971663c2)

        • tika-parser-modules/tika-parser-office-module/src/main/java/org/apache/tika/parser/chm/core/ChmCommons.java
        • CHANGES.txt
        • tika-parser-modules/tika-parser-office-module/src/main/java/org/apache/tika/parser/chm/core/ChmExtractor.java
        • tika-parser-modules/tika-parser-office-module/src/main/java/org/apache/tika/parser/chm/accessor/ChmDirectoryListingSet.java
        • tika-parser-modules/tika-parser-office-module/src/test/java/org/apache/tika/parser/chm/TestChmExtractor.java
        • tika-parser-modules/tika-parser-office-module/src/main/java/org/apache/tika/parser/chm/lzx/ChmLzxBlock.java
        • tika-test-resources/src/test/resources/test-documents/testChm_oom.chm
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in tika-2.x #126 (See https://builds.apache.org/job/tika-2.x/126/ ) TIKA-2040 - prevent permanent hang/oom on corrupt chm file (tallison: rev 1c582aba6b97e2579a3f468bc24ebfa3971663c2) tika-parser-modules/tika-parser-office-module/src/main/java/org/apache/tika/parser/chm/core/ChmCommons.java CHANGES.txt tika-parser-modules/tika-parser-office-module/src/main/java/org/apache/tika/parser/chm/core/ChmExtractor.java tika-parser-modules/tika-parser-office-module/src/main/java/org/apache/tika/parser/chm/accessor/ChmDirectoryListingSet.java tika-parser-modules/tika-parser-office-module/src/test/java/org/apache/tika/parser/chm/TestChmExtractor.java tika-parser-modules/tika-parser-office-module/src/main/java/org/apache/tika/parser/chm/lzx/ChmLzxBlock.java tika-test-resources/src/test/resources/test-documents/testChm_oom.chm
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tika-trunk #1087 (See https://builds.apache.org/job/Tika-trunk/1087/)
        TIKA-2040 - prevent permanent hang/oom on corrupt chm file (tallison: rev 71cb9363c07839e68712edde4626d53aa928cc2a)

        • tika-parsers/src/test/java/org/apache/tika/parser/chm/TestChmExtractor.java
        • tika-parsers/src/main/java/org/apache/tika/parser/chm/core/ChmExtractor.java
        • tika-parsers/src/main/java/org/apache/tika/parser/chm/core/ChmCommons.java
        • tika-parsers/src/test/resources/test-documents/testChm_oom.chm
        • CHANGES.txt
        • tika-parsers/src/main/java/org/apache/tika/parser/chm/accessor/ChmDirectoryListingSet.java
        • tika-parsers/src/main/java/org/apache/tika/parser/chm/lzx/ChmLzxBlock.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tika-trunk #1087 (See https://builds.apache.org/job/Tika-trunk/1087/ ) TIKA-2040 - prevent permanent hang/oom on corrupt chm file (tallison: rev 71cb9363c07839e68712edde4626d53aa928cc2a) tika-parsers/src/test/java/org/apache/tika/parser/chm/TestChmExtractor.java tika-parsers/src/main/java/org/apache/tika/parser/chm/core/ChmExtractor.java tika-parsers/src/main/java/org/apache/tika/parser/chm/core/ChmCommons.java tika-parsers/src/test/resources/test-documents/testChm_oom.chm CHANGES.txt tika-parsers/src/main/java/org/apache/tika/parser/chm/accessor/ChmDirectoryListingSet.java tika-parsers/src/main/java/org/apache/tika/parser/chm/lzx/ChmLzxBlock.java
        Hide
        lfcnassif Luis Filipe Nassif added a comment -

        I have to thank you Tim Allison, the fix was so fast!

        Show
        lfcnassif Luis Filipe Nassif added a comment - I have to thank you Tim Allison , the fix was so fast!

          People

          • Assignee:
            tallison@mitre.org Tim Allison
            Reporter:
            lfcnassif Luis Filipe Nassif
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development