[TIKA-1706] Bring back commons-io to tika-core

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.0.0
• Component/s: core
• Assignee: Unassigned
• Reporter: Yaniv Kunda
• Created: 12/Aug/15 22:04
• Updated: 19/Jul/21 15:17
• Resolved: 19/Jul/21 12:03

Description

TIKA-249 inlined select commons-io classes in order to simplify the dependency tree and save some space.
I believe these arguments are weaker nowadays due to the following concerns:

• Most of the non-core modules already use commons-io, and since tika-core is usually not used by itself, commons-io is already included with it
• Since some modules use both tika-core and commons-io, it's not clear which code should be used
• Having the inlined classes causes more maintenance and/or technology debt (which in turn causes more maintenance)
• Newer commons-io code utilizes newer platform code, e.g. using Charset objects instead of encoding names, being able to use StringBuilder instead of StringBuffer, and so on.

I'll be happy to provide a patch to replace usages of the inlined classes with commons-io classes if this is accepted.

Issue Links

• relates to: TIKA-1710 Replace usages of classes in org.apache.tika.io with current alternatives