Uploaded image for project: 'Tika'
  1. Tika
  2. TIKA-1706

Bring back commons-io to tika-core

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: 2.0, 1.17
    • Component/s: core
    • Labels:
      None

      Description

      TIKA-249 inlined select commons-io classes in order to simplify the dependency tree and save some space.
      I believe these arguments are weaker nowadays due to the following concerns:

      • Most of the non-core modules already use commons-io, and since tika-core is usually not used by itself, commons-io is already included with it
      • Since some modules use both tika-core and commons-io, it's not clear which code should be used
      • Having the inlined classes causes more maintenance and/or technology debt (which in turn causes more maintenance)
      • Newer commons-io code utilizes newer platform code, e.g. using Charset objects instead of encoding names, being able to use StringBuilder instead of StringBuffer, and so on.

      I'll be happy to provide a patch to replace usages of the inlined classes with commons-io classes if this is accepted.

        Attachments

        1. TIKA-1706-2.patch
          10 kB
          Yaniv Kunda
        2. TIKA-1706-1.patch
          95 kB
          Yaniv Kunda

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                kunda Yaniv Kunda
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated: