[THRIFT-993] Some improvements in C++ stubs for oneway operations

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.7
• Component/s: C++ - Compiler
• Patch Info: Patch Available
• Assignee: Unassigned
• Reporter: Rich Salz
• Created: 08/Nov/10 16:54
• Updated: 09/Mar/11 18:17
• Resolved: 27/Jan/11 21:06

Description

Oneway operations don't use the seqid or oprot parameters, so the generated stub should use unnamed parameters for those.

While changing this I noticed that tfunction->is_oneway() is called many times, so cache that result in a local variable.

While making that change, I noticed what seems to be an extraneous test for that, inside a loop which is already inside an if branch. I just commented that.

So far, these changes make generated thrift stubs pass g++ -Wunused cleanly.