Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-955

Thrift compiler for Windows uses lowercase names and directories which is inconsistent with compiling on other platforms

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    Description

      Using thrift compiler 0.5.0 for windows found at: http://incubator.apache.org/thrift/download/ the compiler produces lowercase files and paths rather than honoring the capitalization of the thrift file. However using the compiler on other platforms (I've tested OS X specifically), or an older compiler for windows found on the wiki, the name follows the capitalization of the thrift file.

      Windows compiler now compiling AdminService.thrift you get:
      ./gen-php/adminservice/adminservice_constants.php
      ./gen-php/adminservice/adminservice_types.php
      ./gen-php/adminservice/AdminService.php

      What you get on other OSes and what you used to get on older versions of windows compiler:
      ./gen-php/AdminService/AdminService_constants.php
      ./gen-php/AdminService/AdminService_types.php
      ./gen-php/AdminService/AdminService.php

      This is an inconsistency that can cause lots of headaches for developers when they are in a mixed environment using both windows and other OSes to compile thrift files. It makes it easy to get the wrong case and can cause problems for a case sensitive file system. It seems that the compiler should behave the same regardless of the platform.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            roger Roger Meier
            whitingj Jeff Whiting
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment