[THRIFT-911] (JavaScript compiler) Const structs, maps, sets, and lists generate a trailing comma

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.4
• Fix Version/s: 0.5
• Component/s: JavaScript - Compiler
• Patch Info: Patch Available
• Assignee: T Jake Luciani
• Reporter: Ilya Maykov
• Created: 21/Sep/10 18:50
• Updated: 01/Nov/11 02:52
• Resolved: 22/Sep/10 02:33

Description

The JavaScript compiler generates a trailing comma when compiling non-primitive constants. For example, this thrift code:

namespace js Toy
const map<byte,string> TOY_MAP = {
1 : "ONE",
2 : "TWO",
3 : "THREE"
}

generates this JavaScript code:

Toy.TOY_MAP = {1 : 'ONE',
2 : 'TWO',
3 : 'THREE',
}

According to Google's Closure compiler, this will breaks in some versions of IE. We have a patch available and would like to submit it to trunk.
The bug is present in at least 0.4.0 and in trunk as of revision r999487.