Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-867

PHP accelerator module's output transport is incompatible with TFramedTransport

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 0.4
    • 0.7
    • PHP - Library
    • None

    Description

      I think we've figured out the cause of everyone's problems with THRIFT-837. The patch itself is fine; however, in fixing that bug, we've exposed the fact that PHPOutputTransport erroneously calls down to the underlying PHP transport's flush() method every time the internal 8k buffer is flushed. This is fine for the buffered transport, but unacceptable for the framed transport, which should only be flushed once per RPC call.

      It seems like what we need to do is separate the "internal" buffer flushes from the "external" transport flushes. If we do that, everything should work out fine.

      Attachments

        1. thrift-867.diff
          0.4 kB
          Arya Goudarzi
        2. thrift-tframedtransport-867.patch
          0.5 kB
          Nicholas Telford

        Activity

          People

            Unassigned Unassigned
            bryanduxbury Bryan Duxbury
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: