Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-857

tests run by "make install" fail if generators are disabled

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 0.4
    • 0.8
    • Test Suite
    • None
    • mac os

    Description

      configuring with generators disabled (configure --disable-gen-java, for example) produces a failed build because the tests run by "make install" require the java, cpp, rb, perl, csharp, and js generators.

      I would personally favor either removing those --disble-gen options altogether, or adding a warning message in the configure --help output that disabling those generators is not recommended/will cause test failure.

      Attachments

        1. thrift-857.patch
          6 kB
          Jake Farrell
        2. generator-subnamespace.patch
          4 kB
          Bruce Lowekamp
        3. check-requested-generator.patch
          3 kB
          Bruce Lowekamp

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            jfarrell Jake Farrell
            lowekamp Bruce Lowekamp
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment