[THRIFT-825] Erlang API improvement: allow to use atoms and tuples to point at the thrift client

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Invalid
• Component/s: Erlang - Compiler

Environment

Any environment

• Patch Info: Patch Available
• Assignee: Unassigned
• Reporter: Dmitry Demeshchuk
• Created: 22/Jul/10 08:14
• Updated: 20/Aug/10 18:39
• Resolved: 20/Aug/10 18:38

Description

Here's the code from thrift_client.erl:

call(Client, Function, Args)
when is_pid(Client), is_atom(Function), is_list(Args) ->
case gen_server:call(Client,

{call, Function, Args}

) of
R =

{ok, _}

-> R;
R =

{error, _}

-> R;

{exception, Exception}

-> throw(Exception)
end.

But one may want to use the Client variable as an atom (using erlang:register()) or as a tuple

{Node, Pid}

.

So, it's better to remove the is_pid() check. If the Client variable is invalid - OTP will just raise the "noproc" exception.