Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-817

Syntax Error in concurrency/Mutex.h

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 0.3
    • None
    • None
    • None
    • all

    Description

      I installed Thrift 0.3.0. When I compile my app, I get the following error:

      /usr/local/include/thrift/concurrency/Mutex.h:136: error: comma at end of
      enumerator list

      Looking into this file, there is an extraneous trailing comma:

      enum RWGuardType {
      RW_READ = 0,
      RW_WRITE = 1,
      };

      Attachments

        1. THRIFT-817.patch
          0.4 kB
          noomerikal

        Activity

          Code in head currently looks like this:

          132 // Can be used as second argument to RWGuard to make code more readable
          133 // as to whether we're doing acquireRead() or acquireWrite().
          134 enum RWGuardType {
          135   RW_READ = 0,
          136   RW_WRITE = 1
          137 };
          

          (numbers are line numbers)

          clavoie Christian Lavoie added a comment - Code in head currently looks like this: 132 // Can be used as second argument to RWGuard to make code more readable 133 // as to whether we're doing acquireRead() or acquireWrite(). 134 enum RWGuardType { 135 RW_READ = 0, 136 RW_WRITE = 1 137 }; (numbers are line numbers)
          roger Roger Meier added a comment -

          fixed with a commit for THRIFT-916

          roger Roger Meier added a comment - fixed with a commit for THRIFT-916

          People

            roger Roger Meier
            nuggetwheat Doug Judd
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: