[THRIFT-807] JavaScript: Initialization of Base Types with 0 instead of null

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.3
• Fix Version/s: 0.6
• Component/s: JavaScript - Compiler
• Patch Info: Patch Available
• Assignee: Roger Meier
• Reporter: Roger Meier
• Created: 18/Jun/10 18:13
• Updated: 02/May/13 02:29
• Resolved: 15/Oct/10 19:14

Description

I had a problem with the exception avaliable on the tutorial.
i32 calculate(1:i32 logid, 2:Work w) throws (1:InvalidOperation ouch),

It couldn't be thrown because initialization of numeric base types is done with 0 instead of null and the checks do compare against null.
This was not visible with the Tests provided with first patch for JavaScript bindings above, the ThriftTest.thrift definition does not have a combination of a base type return value and an exception.

I've made a patch that initializes the base types I16,I32, I64 and DOUBLE with null. This could probably solve other issues as well

Regards

Roger

Issue Links

• is depended upon by: THRIFT-893 add JavaScript to the tutorial examples