Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-761

Include the symbolic name of a typedef field in the field metadata [patch]

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 0.2
    • 0.3
    • Java - Compiler
    • None
    • All

    • Patch Available

    Description

      The generator of Java code translates all Thrift typedefs to the appropriate Java types. This means that the Thrift typedef name (aka symbolic name) is being lost during Java code generation.

      The typedef symbolic name should be included in the field value meta data so that it is available for those who inspect metadata of their Thrift data structures.

      FieldValueMetaData, which is the base class for metadata of field values of all types, already has isStruct(), isContainer() and type and is therefore a natural choice for this.

      We should introduce isTypedef() and getTypedefName() into class FieldValueMetaData.

      A patch is attached.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            bryanduxbury Bryan Duxbury
            mdouglas Michael Douglas
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment