Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-758

incorrect deference in exception handling

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.2, 0.3
    • Fix Version/s: 0.5
    • Component/s: Perl - Compiler
    • Labels:
      None
    • Environment:

      thrift from github mirror. Mac OS 10.6.3

    • Patch Info:
      Patch Available

      Description

      This is a nasty error that is triggered during exception, leaving
      the user clueless about the error since she gets a Perl error
      instead:

      "Can't use string ("0") as a SCALAR ref while "strict refs" in use"

      For instance:
      http://stackoverflow.com/questions/2488783/why-do-i-get-an-error-when-insert

      1. yann.patch
        1 kB
        Yann Kerherve

        Activity

        Hide
        bryanduxbury Bryan Duxbury added a comment -

        I just committed this patch.

        Show
        bryanduxbury Bryan Duxbury added a comment - I just committed this patch.
        Hide
        yannk Yann Kerherve added a comment -

        Jake,

        I unfortunately have no clue how to generate a TApplicationException with the provided ThriftTest.

        I didn't find a way to run the tests automatically either. I manually executed:
        perl -Iblib/lib -Ilib -Itest/gen-perl test/processor.t

        Thanks,

        Yann

        Show
        yannk Yann Kerherve added a comment - Jake, I unfortunately have no clue how to generate a TApplicationException with the provided ThriftTest. I didn't find a way to run the tests automatically either. I manually executed: perl -Iblib/lib -Ilib -Itest/gen-perl test/processor.t Thanks, Yann
        Hide
        tjake T Jake Luciani added a comment -

        Oh sorry, could you include a test case for this under lib/perl/test please?

        Thanks!

        Show
        tjake T Jake Luciani added a comment - Oh sorry, could you include a test case for this under lib/perl/test please? Thanks!
        Hide
        yannk Yann Kerherve added a comment -

        Done! Thanks Jake.

        Show
        yannk Yann Kerherve added a comment - Done! Thanks Jake.
        Hide
        tjake T Jake Luciani added a comment -

        Hi Yann,

        If you want this patch applied, then you'll need to attach it to the JIRA this is the ASF protocol and will ensure there are no licensing issues.

        Thanks!

        Show
        tjake T Jake Luciani added a comment - Hi Yann, If you want this patch applied, then you'll need to attach it to the JIRA this is the ASF protocol and will ensure there are no licensing issues. Thanks!
        Hide
        yannk Yann Kerherve added a comment -
        Show
        yannk Yann Kerherve added a comment - Please see patch in my github fork: http://github.com/yannk/thrift/commit/4f54015ac02dc33ea4ae22c8b80389e5d6ee9ae6

          People

          • Assignee:
            yannk Yann Kerherve
            Reporter:
            yannk Yann Kerherve
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development