Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-754

Improvements to varint reading in Compact Protocol

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 0.3
    • 0.3
    • Java - Library
    • None

    Description

      I've found a way to make better use of direct buffer access in the Compact Protocol that makes reading varints faster. When there's at least 5 or 10 bytes available in the buffer, we can try to do the whole varint deserialization from the buffer rather than byte by byte, and ultimately only consume the bytes we used. This lets us avoid the cost of going back and forth from the buffer 1-10 times.

      Attachments

        1. thrift-754.patch
          2 kB
          Bryan Duxbury

        Activity

          People

            bryanduxbury Bryan Duxbury
            bryanduxbury Bryan Duxbury
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: