Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-753

Don't look up TFieldIdEnum values with a map

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 0.3
    • 0.3
    • Java - Compiler
    • None

    Description

      Each struct's internal _Fields class currently generates and uses a HashMap to allow lookup of enum values by thrift field id. This can be a bit slow - it requires us to box an Integer, then hash it, then perform the lookup. We can probably get by with generating a case statement.

      Attachments

        1. thrift-753.patch
          2 kB
          Bryan Duxbury

        Activity

          People

            bryanduxbury Bryan Duxbury
            bryanduxbury Bryan Duxbury
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: