[THRIFT-749] C++ TBufferedTransports do not flush their buffers on delete

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Cannot Reproduce
• Affects Version/s: 0.2, 0.3
• Fix Version/s: 0.10.0
• Component/s: C++ - Library

Environment

Cygwin 1.7.1 on Windows XP SP3, Thrift 0.2.0 & r760184 & Trunk

• Assignee: Unassigned
• Reporter: Tim Wilson-Brown
• Created: 01/Apr/10 11:39
• Updated: 06/Jan/16 02:06
• Resolved: 29/Nov/15 16:24

Description

Edit: replaced 'close underlying transport' with 'flush buffers'

The C++ TBufferedTransports (such as TBufferedTransport) do not flush their buffers on delete.

The workaround is to manually flush the TBufferedTransport before deleting it. If the TBufferedTransport owned the last instance of the underlying transport, it will be deleted and close itself.

This may be worth fixing - at the moment, substituting a buffered TSocket for an unbuffered one changes the behaviour on delete.
Data may be buffered then lost when the TBufferedTransport is deleted.
This is undesirable - they should behave identically except for the buffering.