[THRIFT-746] Generated services Iface/Client inner classes do not derive from base classes

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.2
• Fix Version/s: 0.3
• Component/s: Java - Compiler

Environment

All

• Assignee: Mathias Herberts
• Reporter: Mathias Herberts
• Created: 31/Mar/10 10:35
• Updated: 03/Apr/10 23:20
• Resolved: 03/Apr/10 23:20

Description

When defining a service in Thrift, the generated code looks like

public class Service {
public interface Iface

{ ... }

public static class Client

{ ... }

}

This makes it quite hard to create generic classes which accept any kind of Client or Iface as a parameter. One such use case is the pooling of Client objects.

One way to circumvent this is to create a top level thrift service and have all other services extend it, but then there will be no coherency across the thrift community.

What about introducing a TService class:

public class TService {
public interface Iface {}
public static class Client {
public Client(TProtocol prot)

{ this(prot,prot); }

public Client(TProtocol iprot, TProtocol oprot) {}
}
}

and have generated services inherit from it:

public class Service {
public interface Iface extends TService.Iface {
}
public static class Client extends TService.Client {
}
}

As a bonus I'll contribute the pooling mechanism I've created for Bibale (based on GenericObjectPool).