[THRIFT-719] Update Nonblocking and HsHa server to avoid an extra buffer copy

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.3
• Fix Version/s: 0.3
• Assignee: Bryan Duxbury
• Reporter: Bryan Duxbury
• Created: 01/Mar/10 17:49
• Updated: 26/Mar/10 05:14
• Resolved: 26/Mar/10 05:14

Description

Nonblocking and HsHa servers are currently built in such a way that the memory buffer transport that actually contains the whole read message will be wrapped in a new TFramedTransport, which means the first time that you read from this transport, you'll end up copying the whole buffer again.

I'd like to just use a straight TMemoryInputTransport, and stop offering the option of specifying an input transport factory. Doing so is simple, but it has one side effect: you wouldn't be able to customize that transport through use of a Transport Factory. However, I think that it's just too likely someone will screw up either the functionality or the performance of the server by doing so.