[THRIFT-713] Java compareTo method throws NPE when any field isn't set.

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.3
• Component/s: Java - Compiler
• Patch Info: Patch Available
• Assignee: Bryan Duxbury
• Reporter: Dmitry Chechik
• Created: 22/Feb/10 19:34
• Updated: 23/Feb/10 19:06
• Resolved: 23/Feb/10 19:06

Description

On line 1395 of t_java_generator.cc, the code is:
indent(out) << "lastComparison = Boolean.valueOf(" << generate_isset_check(field) << ").compareTo(" << generate_isset_check(field) << ");" << endl;

So isSet*() of the object being compared is just compared to the same object. This throws a NPE if the field isn't set.

I've attached a fix patch.