Thrift
  1. Thrift
  2. THRIFT-707

Support old-style constructors for Union structs

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.2
    • Fix Version/s: 0.3
    • Component/s: Ruby - Library
    • Labels:
      None

      Description

      It would be pretty handy if the new Union struct constructors could also take in the old-style hash constructor. This would lead to less code breakage.

      1. thrift-707.patch
        1 kB
        Bryan Duxbury

        Activity

        Hide
        Bryan Duxbury added a comment -

        I just committed this patch.

        Show
        Bryan Duxbury added a comment - I just committed this patch.
        Hide
        Bryan Duxbury added a comment -

        This patch make the constructor check if the first arg is a hash, and if so, it unwraps it before carrying on.

        If there are no objections, I will commit this today.

        Show
        Bryan Duxbury added a comment - This patch make the constructor check if the first arg is a hash, and if so, it unwraps it before carrying on. If there are no objections, I will commit this today.

          People

          • Assignee:
            Bryan Duxbury
            Reporter:
            Bryan Duxbury
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development