[THRIFT-663] JavaBean code generator produces incorrect setter methods

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.2
• Fix Version/s: 0.3
• Component/s: Java - Compiler
• Patch Info: Patch Available
• Assignee: Bryan Duxbury
• Reporter: Dave Engberg
• Created: 19/Dec/09 03:37
• Updated: 03/Apr/10 05:11
• Resolved: 03/Apr/10 05:11

Description

The original Thrift JavaBean generator produced set* methods for a property 'foo' that looked like:

public void setFoo(int foo) {
this.foo = foo;
}

The more recent code in the 0.2.0 release now returns a value:

public MyStruct setFoo(int foo) {
this.foo = foo;
return this;
}

I can imagine this was possibly desired by someone to implement a "chaining" style of coding, but this is no longer a correct JavaBean. The JavaBean spec requires that the return type of set* functions be 'void', and various tools and frameworks enforce this requirement. For example, the Stripes web UI toolkit thinks that a field is read-only if the set* function doesn't return 'void'.

I'll attach a trivial patch to restore this to the previous behavior. If a chaining-style setter is desired by others, I'd recommend making this a separate method on the bean rather than replacing the standard setter. E.g.:

public MyStruct setChainFoo(int foo) { ...

Or something like that.