[THRIFT-590] send/recv timeout values interchanged in perl socket lib

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.1
• Component/s: Perl - Library
• Patch Info: Patch Available
• Assignee: Jon Schutz
• Reporter: Jon Schutz
• Created: 24/Sep/09 07:56
• Updated: 01/Nov/11 02:54
• Resolved: 12/Nov/09 02:36

Description

In current version of code, sendTimeout is used in read() and recvTimeout is used in write(). Should be the other way around.

Simple fix:

Index: lib/perl/lib/Thrift/Socket.pm
===================================================================
— lib/perl/lib/Thrift/Socket.pm (revision 818395)
+++ lib/perl/lib/Thrift/Socket.pm (working copy)
@@ -196,7 +196,7 @@
return unless defined $self->

{handle};

#check for timeout
- my @sockets = $self->{handle}

>can_read( $self>

{sendTimeout} / 1000 );
+ my @sockets = $self->{handle}>can_read( $self>{recvTimeout} / 1000 );

if(@sockets == 0){
die new Thrift::TException('TSocket: timed out reading '.$len.' bytes from '.
@@ -236,7 +236,7 @@


#check for timeout
- my @sockets = $self->{handle}->can_write( $self->{recvTimeout} / 1000 );
+ my @sockets = $self->{handle}->can_write( $self->{sendTimeout}

/ 1000 );

if(@sockets == 0){
die new Thrift::TException('TSocket: timed out writing to bytes from '.