[THRIFT-587] TNonblockingServer connect code fails on 64-bit OS

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.1
• Fix Version/s: 0.2
• Component/s: C++ - Library

Environment

Mac Os X 10.6.1 (Snow Leopard)

• Patch Info: Patch Available
• Assignee: Unassigned
• Reporter: Rush Manbert
• Created: 19/Sep/09 00:53
• Updated: 01/Nov/11 02:51
• Resolved: 19/Sep/09 01:59

Description

The non-blocking stress test gets SIGABORT if more than 2 clients try to connect.

The reason for this is in TNonblockingServer::handleEvent(). It sets addrLen once, before the loop that calls accept(), but accept() writes the size of the stored address into the addrLen pointer argument. Running on OS X 10.6.x, the returned value is 28, where it was originally 16. The second call to accept() overwrites the stack canary data and __stack_chk_fail gets called and we're toast.

The fix is to reinitialize addrLen at the end of the loop before we call accept() again.

I will attach a patch.