[THRIFT-5785] TTransportException.h includes 'boost/numeric/conversion/cast.hpp' without target depending on Boost

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 0.20.0

Environment

• macOS 14 (Sonoma)
• Host is x86_64, cross-compiling universal binaries for x86_64+aarch64
• CMake 3.29, dependencies managed through conventional use of find_package()
• AppleClang 15.0.0.15000100
• Compiling with -std=gnu++20
• Boost 1.81 (from MacPorts)
• Apache Thrift 0.20 (from MacPorts, recently upgraded)

• Assignee: Unassigned
• Reporter: Petr Mánek
• Created: 13/May/24 12:21
• Updated: 29/May/24 08:15

Description

Hello, ever since upgrading from version 0.19 to 0.20, I am seeing a new error when compiling my Thrift-based software:

In file included from /redacted/RemoteControl.cpp:7:
In file included from /redacted/RemoteControl.h:10:
In file included from /opt/local/lib/../include/thrift/TDispatchProcessor.h:22:
In file included from /opt/local/lib/../include/thrift/TProcessor.h:24:
In file included from /opt/local/lib/../include/thrift/protocol/TProtocol.h:46:
In file included from /opt/local/lib/../include/thrift/transport/TTransport.h:25:
/opt/local/lib/../include/thrift/transport/TTransportException.h:23:10: fatal error: 'boost/numeric/conversion/cast.hpp' file not found
#include <boost/numeric/conversion/cast.hpp> 

I have confirmed that 'cast.hpp' is correctly installed in my system, but for some reason CMake does not add its include path to compiler invocation, so the file is not seen during compilation. Furthermore, based on synthesized compiler flags it seems that Thrift's CMake package does not declare public dependency on boost::numeric, but nonetheless includes it in public headers. This may be related to THRIFT-5660.

For now I mitigate this issue by making my CMake target explicitly depend on Apache Thrift as well as boost::numeric. However, since I do not directly use Boost whereas Thrift does, I should not have to do that. Instead, it seems much more cleaner to me if Thrift publicly depended on boost::numeric or removed the offending #include directive from its public headers.