Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-5731

go: Handle client connectivity check in server automatically

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 0.19.0
    • Go - Compiler
    • None

    Description

      We added connectivity check for each request on compiler generated server processor code in THRIFT-5240. It requires the server endpoint implementation to actually check for context error and return thrift.ErrAbandonRequest instead.

      Now with minimal supported go version raised to 1.20, it's actually possible for compiler generated code to handle all those automatically, as long as the endpoint returns ctx.Err(), by using the new context.WithCancelCause API added in go 1.20.

      Attachments

        Issue Links

          Activity

            People

              fishywang Yuxuan Wang
              fishywang Yuxuan Wang
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 20m
                  20m