[THRIFT-570] Thrift compiler does not error when duplicate method names are present

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.4
• Component/s: C# - Compiler, C++ - Compiler, Cocoa - Compiler, Compiler (General), Erlang - Compiler, Haskell - Compiler, Java - Compiler, Perl - Compiler, PHP - Compiler, Python - Compiler, Ruby - Compiler
• Assignee: Bruce Simpson
• Reporter: Rob Slifka
• Created: 31/Aug/09 19:42
• Updated: 12/Aug/10 01:51
• Resolved: 12/Aug/10 01:51

Description

Thrift does not support method overloading. However, the Thrift compiler reports success when duplicate methods are seen in a service definition.

Thrift compiles this successfully, however the generated code will not compile.

#!/usr/local/bin/thrift --gen java
namespace java tutorial
service Calculator {
    i32 add(1:i32 num1, 2:i32 num2),
    string add(1:string str1, 2:string str2),
}