[THRIFT-5685] Compiler generates wrong go code for forward defined types in optional fields

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.18.0
• Fix Version/s: 0.18.1
• Component/s: Go - Compiler
• Assignee: Yuxuan Wang
• Reporter: Yuxuan Wang
• Created: 15/Feb/23 17:18
• Updated: 11/Oct/24 00:51
• Resolved: 21/Feb/23 21:59

Description

This is a bug introduced by the fix of THRIFT-5601.

Given this thrift file:

struct Bar {
  1: optional Foo bar
}

struct Foo {
  1: optional i64 foo
}

0.18.0 with b39370ec3bc96d2 reverted will generate the following go code (expected):

...
var Bar_Bar_DEFAULT *Foo
func (p *Bar) GetBar() *Foo {
  if !p.IsSetBar() {
    return Bar_Bar_DEFAULT
  }
return p.Bar
}
...

while 0.18.0 generates:

...
var Bar_Bar_DEFAULT Foo
func (p *Bar) GetBar() Foo {
  if !p.IsSetBar() {
    return Bar_Bar_DEFAULT
  }
return *p.Bar
}
...

This makes usages like bar.GetBar().GetFoo() no longer compiles because GetBar now returns non-pointer type.

Issue Links

• causes: THRIFT-5823 Fix illegal uses of exceptions as normal struct type
• is broken by: THRIFT-5601 Typedef after first use causes incorrect go code
• links to: GitHub Pull Request #2759