[THRIFT-5656] Escape Delphi keywords with '&' prefix instead of '_' suffix

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.18.0
• Component/s: Delphi - Compiler
• Labels: breaking_change
• Patch Info: Patch Available
• Assignee: Jens Geyer
• Reporter: Jens Geyer
• Created: 17/Oct/22 13:26
• Updated: 13/Feb/23 21:10
• Resolved: 17/Oct/22 19:25

Description

Currently the Delphi compiler does not differentiate between real Delphi language keywords (that can be escaped via & prefix) and predefined names/types that must be handled differently (we do this by adding a underscore postfix so it becomes e.g. 'System_' instead of 'System' which would collide with the Delphi runtime unit of that name).

This patch addresses this and handles keywords properly with '&' by default.

Compatibility: This may break code if one of the Delphi keywords has been used in the IDL. 

Workaround. The old behaviour can be restored via Thrift compiler switch.

Issue Links

• links to: GitHub Pull Request #2716