[THRIFT-5636] Broken client in erlang client library

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.17.0
• Fix Version/s: 0.18.0
• Component/s: Erlang - Library
• Assignee: Sergey Yelin
• Reporter: Sergey Yelin
• Created: 22/Sep/22 10:56
• Updated: 13/Feb/23 21:10
• Resolved: 23/Sep/22 06:44

Description

It looks like erlang client library are broken since this fix.

Now some of read tests for thrift_socket_transport module fail because of timeout while waiting data from the mocked gen_tcp:recv/3 call (because of infinite loop in thrift_socket_transport:loop_recv/3). 

In production, calling to thrift_socket_transport:read/2 will lead to infinite loop if remote server stop sending data to socket or received data size is less than requested.

It looks like gen_tcp:recv/3 should not try to receive all data from socket (passing 0 to call) and not try to retrieve big amount of data (hiding underlying call), but set some reasonable value and get data by chunks or passing control flow to client.

Issue Links

• links to: GitHub Pull Request #2674