[THRIFT-5627] More consistent syntax for cpp_type

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.18.0
• Component/s: Compiler (General)
• Assignee: Jens Geyer
• Reporter: Jens Geyer
• Created: 10/Sep/22 23:07
• Updated: 14/Feb/23 00:10
• Resolved: 14/Sep/22 09:49

Description

As a side effect on my current work I recognized an interesting parser warning.

Essentially it boils down to the list<> case in these definitions taken from https://thrift.apache.org/docs/idl which (now) would cause ambiguities.

[28] MapType         ::=  'map' CppType? '<' FieldType ',' FieldType '>'
[29] SetType         ::=  'set' CppType? '<' FieldType '>'
[30] ListType        ::=  'list' '<' FieldType '>' CppType?

I wonder why we need it this way at all. Wouldn't it be better if list<> set<> and map<> would expect the same syntax?

Issue Links

• links to: GitHub Pull Request #2665