[THRIFT-5599] contrib/fb303 does not compile after C++ library refactorings

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.13.0, 0.14.0, 0.15.0, 0.14.1, 0.14.2, 0.16.0
• Fix Version/s: 0.17.0
• Component/s: Contributed
• Flags: Patch
• External issue URL: https://github.com/apache/thrift/pull/2624
• Assignee: Michael Leinartas
• Reporter: Michael Leinartas
• Created: 21/Jun/22 16:13
• Updated: 26/Oct/22 23:46
• Resolved: 21/Jun/22 20:29

Description

contrib/fb303 no longer compiles after THRIFT-4730 removed ReadWriteMutex.

The ReadWriteMutex used by fb303 is protecting counter statistics. These are very write-heavy and read-light (these are read only when the Service methods getCounters() or getCounter() are called). Because of this, retaining a read-write mutex to protect these counters is unjustified and we can safely swap this out for a normal Mutex.

Compilation also fails after THRIFT-5168 removed generation of *_constants.cpp and *_constants.h generation because the fb303 Makefile explicitly depends on these unnecessary files

Issue Links

• links to: GitHub Pull Request #2624