Thrift
  1. Thrift
  2. THRIFT-554

Perl improper namespace check for exception handling and writeMessageEnd missing on processor calls

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.2
    • Component/s: Perl - Compiler
    • Labels:
      None
    • Environment:

      Ubuntu Jaunty x86_64

    • Patch Info:
      Patch Available

      Description

      There are two more issues affecting the functioning of a Perl service server:
      1. Failure to prepend the Perl namespace to the exception name when checking the exception type from a eval'ed method call.
      2. writeMessageEnd() should be present after a method call writes its result.

      I'm attaching a patch which addresses these issues, in addition to the following more minor changes:
      1. Tried to make indentation and line breaks more consistent to ensure readability of the generated code.
      2. Added a few best practice ideas to improve the code in minor ways.
      3. Added a readAll() function to the Thrift::MemoryBuffer, as the one found in Thrift::Transport uses a while loop to consume the data, which results in a endless loop.

      1. thrift-554.diff
        13 kB
        Eric Waters

        Activity

        Jake Farrell made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        T Jake Luciani made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 0.2 [ 12313769 ]
        Resolution Fixed [ 1 ]
        Eric Waters made changes -
        Priority Major [ 3 ] Minor [ 4 ]
        Eric Waters made changes -
        Field Original Value New Value
        Attachment thrift-554.diff [ 12414956 ]
        Eric Waters created issue -

          People

          • Assignee:
            Eric Waters
            Reporter:
            Eric Waters
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development