[THRIFT-5539] Performance penalty of using TDebugProtocol.DuplicateTo

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.16.0
• Fix Version/s: 0.17.0
• Component/s: Go - Library
• Assignee: Yuxuan Wang
• Reporter: Yuxuan Wang
• Created: 16/Mar/22 00:29
• Updated: 26/Oct/22 23:46
• Resolved: 16/Mar/22 04:39

Description

Currently go library's TDebugProtocol provides 2 features:

1. debug logging
2. duplicate write the protocol to another protocol (for size counting, etc.)

When someone only need the 2nd feature, they still need to pay the price of the 1st feature, even if they set TDebugProtocol.Logger to NopLogger, as we cannot avoid all the fmt.Sprintf calls, and those calls can waste significant cpu resource (in one of our services, the fmt.Sprintf calls from TDebugProtocol counts to 10% of cpu usage).

Provide a dedicated TDuplicateToProtocol, and deprecate TDebugProtocol.DuplicateTo, to help avoid this performance penalty.

Issue Links

• links to: GitHub Pull Request #2548