[THRIFT-5529] Missing space "<::" in C++ generator

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.16.0
• Fix Version/s: 0.17.0
• Component/s: C++ - Compiler

Environment

Microsoft Visual Studio Professional 2022
Version 17.1.0
VisualStudio.17.Release/17.1.0+32210.238

Language

C++

• Assignee: Andreas Renggli
• Reporter: Andreas Renggli
• Created: 26/Feb/22 06:22
• Updated: 26/Oct/22 23:46
• Resolved: 26/Feb/22 11:59

Description

Autogenerated code in C++ is missing space between "<" and "::" 

e.G.:

 

    if (style == "Concurrent") {
        f_header_ << ", std::shared_ptr<::apache::thrift::async::TConcurrentClientSyncInfo> sync";
    }

 

Code cannot be compiled due to needed leading space, in case the name is used inside of a template parameter.  "MyTemplate<::foo::Bar>" is not valid C++, since "<:" is an alternative token for "[". as mentioned here

t_cpp_generator.cc

Issue Links

• links to: GitHub Pull Request #2535