[THRIFT-5519] Java async client loses exceptions in void methods

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.11.0, 0.15.0, 0.16.0
• Fix Version/s: 0.17.0
• Component/s: Java - Compiler

Language

java

• Assignee: Alex Kormukhin
• Reporter: Alex Kormukhin
• Created: 18/Feb/22 15:57
• Updated: 26/Oct/22 23:46
• Resolved: 02/Mar/22 21:15

Description

Exceptions thrown in void methods are lost on the client side when using an asynchronous Java client.

 

For non-void methods, generated getResult() looks like this:

 

public java.lang.String getResult() throws TExampleException, org.apache.thrift.TException {
  if (getState() != org.apache.thrift.async.TAsyncMethodCall.State.RESPONSE_READ) {
    throw new java.lang.IllegalStateException("Method call not finished!");
  }
  org.apache.thrift.transport.TMemoryInputTransport memoryTransport = new org.apache.thrift.transport.TMemoryInputTransport(getFrameBuffer().array());
  org.apache.thrift.protocol.TProtocol prot = client.getProtocolFactory().getProtocol(memoryTransport);
  return (new Client(prot)).recv_returnString();
}

 

For void methods like:

public Void getResult() throws TExampleException, org.apache.thrift.TException {
  if (getState() != org.apache.thrift.async.TAsyncMethodCall.State.RESPONSE_READ) {
    throw new java.lang.IllegalStateException("Method call not finished!");
  }
  org.apache.thrift.transport.TMemoryInputTransport memoryTransport = new org.apache.thrift.transport.TMemoryInputTransport(getFrameBuffer().array());
  org.apache.thrift.protocol.TProtocol prot = client.getProtocolFactory().getProtocol(memoryTransport);
  return null;
} 

There are no call to (new Client(prot)).recv_returnVoidThrows() here.

But in recv_returnVoidThrows():

public void recv_returnVoidThrows() throws TExampleException, org.apache.thrift.TException
{
  returnVoidThrows_result result = new returnVoidThrows_result();
  receiveBase(result, "returnVoidThrows");
  if (result.error != null) {
    throw result.error;
  }
  return;
} 

the received response is read and the received exceptions are thrown.

 

The correct getResult() for void methods should look like this:

public Void getResult() throws TExampleException, org.apache.thrift.TException {
  if (getState() != org.apache.thrift.async.TAsyncMethodCall.State.RESPONSE_READ) {
    throw new java.lang.IllegalStateException("Method call not finished!");
  }
  org.apache.thrift.transport.TMemoryInputTransport memoryTransport = new org.apache.thrift.transport.TMemoryInputTransport(getFrameBuffer().array());
  org.apache.thrift.protocol.TProtocol prot = client.getProtocolFactory().getProtocol(memoryTransport);
  (new Client(prot)).recv_returnVoidThrows();
  return null;
} 

 

Attached test (bug-async-void-meths-lost-exception.zip) demonstrates this issue.

 

Issue Links

• links to: GitHub Pull Request #2534