[THRIFT-5511] Full support for the new net6 "nullability" semantics

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.16.0
• Fix Version/s: 0.17.0
• Component/s: netstd - Compiler

Environment

net6 / C# 10

• Patch Info: Patch Available
• Assignee: Jens Geyer
• Reporter: Jens Geyer
• Created: 05/Feb/22 01:58
• Updated: 26/Oct/22 23:46
• Resolved: 08/Feb/22 16:50

Description

This is sort of an follow-up to THRIFT-5479.

The initially chosen solution was to add an <autogenerate> tag to each generated C# source file, because otherwise the analysis would drop a whole lot of messages onto the user. One major reason behind this design was that it does not break compatibility.

It turned out that that actually may do more harm than good, because of this issue, which has a really great potential to lead the developer into a false security, believing what the IDE tells, that values in some cases are not null - but what it really should say is "I did not analyze this code so I cannot safely tell anything".

Hence, we should have better support for it.

Issue Links

• is duplicated by: THRIFT-5578 #nullable disable collides with C# lang versions < 8 (error CS8370)
• links to: GitHub Pull Request #2516