Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-5502

Is it necessary to report CONNECTION RESET as an ERROR?

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Trivial
    • Resolution: Fixed
    • 0.14.0, 0.14.1
    • 0.17.0
    • Java - Library
    • None

    Description

      I notice that in your Java implementation if a connection throws an exception, you will log it or not depending on the type of the exception. Currently, only two kinds of exceptions will be ignored: TIME_OUT and EOF.

      However, a common case is when a client exits without closing the connection properly, the server will receive CONNECTION RESET instead of EOF. It is very likely that human users will close client programs directly rather than use some "exit" command.

      I understand that it is arguable whether an abnormally-exit client should be reported. But in my opinion, it should at least not generate an ERROR log, as ERROR logs are very sensitive in production systems and may trigger further alerts, while an abnormally-exit client is not actually some error that should be handled by the server maintainers.

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            slachiewicz Sylwester Lachiewicz
            jt2594838 Tian Jiang
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 50m
                50m

                Slack

                  Issue deployment