[THRIFT-5500] Uncompilable code when .thrift struct 'System' exists

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.15.0
• Fix Version/s: 0.16.0
• Component/s: netstd - Compiler

Environment

Visual Studio 2022

.netstandard-2.0 Project

• Assignee: Jens Geyer
• Reporter: Jonas Marty
• Created: 20/Jan/22 13:37
• Updated: 15/Feb/22 21:41
• Resolved: 20/Jan/22 21:13

Description

If you have an struct in your .thrift definition with the name 'System', the thrift compile generates uncompilable code for the Equals() method. As the namespace 'System' gets interpreted as class. It could be fixed with prefixing the  System.Object.Equals() calls with 'global::' as it is done nearly everywhere else where non simple types are used.

The following compiles:

Yes I also think naming a struct 'System' is not a good idea, but here we are

Issue Links

• links to: GitHub Pull Request #2507