[THRIFT-5486] fix issues found by spotbugs

• Type: Technical Debt
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.16.0
• Component/s: Java - Library
• Assignee: Bhalchandra Pandit
• Reporter: Bhalchandra Pandit
• Created: 02/Dec/21 22:13
• Updated: 15/Feb/22 21:41
• Resolved: 18/Dec/21 08:56

Description

Fixes the following issues found by spotbugs:

Private method org.apache.thrift.partial.ThriftMetadata$ThriftPrimitive.getParentStruct() is never called

Private method org.apache.thrift.TDeserializer.createNewStruct(ThriftMetadata$ThriftStruct) is never called

org.apache.thrift.partial.PartialThriftComparer.areEqual(ThriftMetadata$ThriftMap, Object, Object, StringBuilder) makes inefficient use of keySet iterator instead of entrySet iterator

Issue Links

• links to: GitHub Pull Request #2484