[THRIFT-5463] Incorrect and inconsistency in compiler generated go code regarding pointer types

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 0.15.0, 0.14.2
• Component/s: Go - Compiler
• Assignee: Unassigned
• Reporter: Yuxuan Wang
• Created: 10/Sep/21 15:58
• Updated: 10/Sep/21 15:58

Description

This is the continuation/followup from THRIFT-5389 and THRIFT-5461.

1. For container fields of a struct (map/list/set), we make the container type a point when it has default value set, but we didn't handle that correctly when generating the constant value (part of THRIFT-3289 but missed from the fix)
2. The decision on whether to make string/binary fields of a struct's type a pointer is inconsistent from container types. For container types we make it a pointer when it has a default value, so we determine IsSet* by checking if the pointer is nil. But for string we make it not a pointer when it has default value, and determine IsSet* by checking if the value is the same as the default. We should make them consistent.